Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions
From: David Miller <davem@davemloft.net>
Date: 2016-10-04 01:45:40
From: Shmulik Ladkani <redacted> Date: Thu, 29 Sep 2016 14:03:32 +0300
skb2->skb_iif = skb->dev->ifindex; skb2->dev = dev; - err = dev_queue_xmit(skb2); + if (tcf_mirred_act_direction(m_eaction) & AT_EGRESS) + err = dev_queue_xmit(skb2); + else + netif_receive_skb(skb2);
Can you address the feedback about lack of checking the return value of netif_receive_skb()? It seems like a legitimate issue, thanks.