Thread (27 messages) 27 messages, 4 authors, 2016-09-28

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

flat view

From: Cyrill Gorcunov <hidden>
Date: 2016-09-28 13:04:07
Also in: lkml

On Wed, Sep 28, 2016 at 05:57:12AM -0700, Eric Dumazet wrote:
...
Note that some programs could fail to compile with the added union
anyway.

Some gcc versions are unable to compile a static init with an union

struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, };

When I cooked my recent fq commit I simply removed a pad and replaced
it :

git show fefa569a9d4bc4 -- include
Oh, crap :( I've been looking into uapi headers, found that we
use anonymous unions (for example include/uapi/linux/bcache.h)
and thought it will be safe (and my test builds didn't fail).
Are you happen to know which gcc versions cant do that?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help