Thread (27 messages) 27 messages, 4 authors, 2016-09-28

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

flat view

From: Eric Dumazet <hidden>
Date: 2016-09-28 13:02:15
Also in: lkml

On Wed, 2016-09-28 at 05:57 -0700, Eric Dumazet wrote:
Note that some programs could fail to compile with the added union
anyway.

Some gcc versions are unable to compile a static init with an union

struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, };

When I cooked my recent fq commit I simply removed a pad and replaced
it :

git show fefa569a9d4bc4 -- include
This is a bit different of course, since struct tc_fq_qd_stats is only
one way : Kernel produces the content and gives it to user space.

User space should probably not need to initialize such a structure, but
who knows what a programmer can write ;)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help