Re: [net-next PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs

On 2/4/2016 5:18 AM, Amir Vadai" wrote:

On Wed, Feb 03, 2016 at 01:28:37AM -0800, John Fastabend wrote:

quoted

This patch allows netdev drivers to consume cls_u32 offloads via
the ndo_setup_tc ndo op.

This works aligns with how network drivers have been doing qdisc
offloads for mqprio.

Signed-off-by: John Fastabend <redacted>
---

[...]

quoted

+enum {
+	TC_CLSU32_NEW_KNODE,

TC_CLSU32_NEW_KNODE is never used

aha yep that snuck in there. In a follow up patch for the fm10k devices
where we can support hash tables (e.g. divisor > 1) I use it. Although
on closer inspection I need to check that the divisor == 1 on ixgbe or
else abort because we can get out of sync if software expects hash
tables here.

Thanks, nice catch.

[...]