Re: [net-next PATCH 1/7] net: rework ndo tc op to consume additional qdisc handle parameter

Hi John,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/John-Fastabend/tc-offload-for-cls_u32-on-ixgbe/20160203-173342
config: x86_64-randconfig-x005-201605 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from drivers/net/ethernet/intel/fm10k/fm10k.h:24,
                    from drivers/net/ethernet/intel/fm10k/fm10k_netdev.c:21:
   drivers/net/ethernet/intel/fm10k/fm10k_netdev.c: In function '__fm10k_setup_tc':
   drivers/net/ethernet/intel/fm10k/fm10k_netdev.c:1209:16: error: 'TC_H_ROOT' undeclared (first use in this function)
     if (handle != TC_H_ROOT)
                   ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^

quoted

drivers/net/ethernet/intel/fm10k/fm10k_netdev.c:1209:2: note: in expansion of macro 'if'

     if (handle != TC_H_ROOT)
     ^
   drivers/net/ethernet/intel/fm10k/fm10k_netdev.c:1209:16: note: each undeclared identifier is reported only once for each function it appears in
     if (handle != TC_H_ROOT)
                   ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^

quoted

drivers/net/ethernet/intel/fm10k/fm10k_netdev.c:1209:2: note: in expansion of macro 'if'

     if (handle != TC_H_ROOT)
     ^

vim +/if +1209 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c

  1193		/* flag to indicate SWPRI has yet to be updated */
  1194		interface->flags |= FM10K_FLAG_SWPRI_CONFIG;
  1195	
  1196		return 0;
  1197	err_open:
  1198		fm10k_mbx_free_irq(interface);
  1199	err_mbx_irq:
  1200		fm10k_clear_queueing_scheme(interface);
  1201	err_queueing_scheme:
  1202		netif_device_detach(dev);
  1203	
  1204		return err;
  1205	}
  1206	
  1207	static int __fm10k_setup_tc(struct net_device *dev, u32 handle, u8 tc)
  1208	{

1209		if (handle != TC_H_ROOT)

  1210			return -EINVAL;
  1211	
  1212		return fm10k_setup_tc(dev, tc);
  1213	}
  1214	
  1215	static int fm10k_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
  1216	{
  1217		switch (cmd) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation