Re: [PATCH 7/9] rhashtable: Per bucket locks & deferred expansion/shrinking

From
Thomas Graf <tgraf@suug.ch>
Date
2015-01-19 12:58:19
Also in
netfilter-devel
Reply to
Patrick McHardy, 2015-01-17
On 01/17/15 at 08:02am, Patrick McHardy wrote:
On 16.01, Thomas Graf wrote:
quoted
Resize operations should be *really* rare as well unless you start
with really small hash table sizes and constantly add/remove at the
watermark.
Which are far enough from each other that this should only happen
in really unlucky cases.
quoted
Re-dumping on insert/remove is a different story of course. Do you
care about missed insert/removals for dumps? If not we can do the
sequence number consistency checking for resizing only.
No, that has always been undeterministic with netlink. We want to
dump everything that was present when the dump was started and is
still present when it finishes. Anything else can be handled using
notifications.
It looks like we want to provide two ways to resolve this:

1) Walker holds ht->mutex the entire time to block out resizes.
   Optionally the walker can acquire all bucket locks. Such
   scenarios would seem to benefit from either a single or a very
   small number of bucket locks.

2) Walker holds ht->mutex during individual Netlink message
   construction periods and relases it while user space reads the
   message. rhashtable provides a hook which is called when a
   resize operation is scheduled allowing for the walker code to
   bump a sequence number and notify user space that the dump is
   inconsistent, causing it to request a new dump.

I'll provide an API to achieve (2). (1) is already achieveable with
the current API.
Thread (46 messages) 46 messages, 7 authors, last reply 2015-01-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help