Re: [PATCH 7/9] rhashtable: Per bucket locks & deferred expansion/shrinking

From
Patrick McHardy <hidden>
Date
2015-01-16 18:36:33
Also in
netfilter-devel
Reply to
Thomas Graf, 2015-01-16
On 16.01, Thomas Graf wrote:
On 01/16/15 at 04:43pm, David Laight wrote:
quoted
The walker is unlikely to see items that get inserted early in the hash
table even without a resize.
I don't follow, you have to explain this statement.

Walkers which don't want to see duplicates or miss entries should
just take the mutex.
Well, we do have a problem with interrupted dumps. As you know once
the netlink message buffer is full, we return to userspace and
continue dumping during the next read. Expanding obviously changes
the order since we rehash from bucket N to N and 2N, so this will
indeed cause duplicate (doesn't matter) and missed entries.
Thread (46 messages) 46 messages, 7 authors, last reply 2015-01-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help