Re: [PATCH 7/9] rhashtable: Per bucket locks & deferred expansion/shrinking

From
Patrick McHardy <hidden>
Date
2015-01-16 16:32:03
Also in
netfilter-devel
Reply to
Thomas Graf, 2015-01-16
On 16.01, Thomas Graf wrote:
On 01/16/15 at 04:03pm, Patrick McHardy wrote:
quoted
On 16.01, Thomas Graf wrote:
quoted
A walker may not see insertions that occur after the walker was started
if resizing is enabled. Is that a problem for nftables?
No, that would be Ok. The case I'm wondering about is:

- insertion
- resize starts
- another insertion
- walker, resize not finished yet
Correct, walker may not see "another insertion". The window for this
behavior to occur is not the full resize operation, just the linking
period, but it may occur. The length of the window is typically
equal to a grace period.

We can provide a synchronization function to block the dumper or the
insertion/removal until the linking is complete. The latter would
give the old runtime behaviour back (variable runtime of insert),
the blocked dumper might be preferred. What do you think?
If we have to block, the dumper if of course preferred. Taking the
mutex should do fine I guess?

I suppose walking both tables without any races would be rather
complicated.
Thread (46 messages) 46 messages, 7 authors, last reply 2015-01-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help