Re: [PATCH 7/9] rhashtable: Per bucket locks & deferred expansion/shrinking

From
Patrick McHardy <hidden>
Date
2015-01-17 08:02:56
Also in
netfilter-devel
Reply to
Thomas Graf, 2015-01-16
On 16.01, Thomas Graf wrote:
On 01/16/15 at 10:07pm, Patrick McHardy wrote:
quoted
I'm afraid that's not good enough. The resize operation is deferred,
so even if userspace does not perform an operation after starting
the dump, the hash might change.

We can obviously work around that by incrementing a generation
counter in rhashtable. The main problem I see is that with something
very actively changing the ruleset, we might never complete a dump.
Right, I suggest adding a function pointer to rhashtable_params,
which when set, is called on resize so users can bump their own
sequence counter on resize.
quoted
Dumps are usually rare, I think its preferrable to defer rehashing.
Resize operations should be *really* rare as well unless you start
with really small hash table sizes and constantly add/remove at the
watermark.
Which are far enough from each other that this should only happen
in really unlucky cases.
Re-dumping on insert/remove is a different story of course. Do you
care about missed insert/removals for dumps? If not we can do the
sequence number consistency checking for resizing only.
No, that has always been undeterministic with netlink. We want to
dump everything that was present when the dump was started and is
still present when it finishes. Anything else can be handled using
notifications.
Thread (46 messages) 46 messages, 7 authors, last reply 2015-01-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help