Thread (133 messages) flat view 133 messages, 9 authors, 2015-02-03

Re: [RFC] situation with csum_and_copy_... API

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2014-11-22 03:36:42
Also in: lkml

On Sat, Nov 22, 2014 at 03:27:18AM +0000, Al Viro wrote:
  
quoted hunk ↗ jump to hunk
@@ -566,38 +445,15 @@ static size_t copy_to_iter_bvec(void *from, size_t bytes, struct iov_iter *i)
[snip]
+	iterate_bvec(i, bytes, page, off, len, true,
+		     memcpy_from_page((from += len) - len, page, off, len))
should be
+		     memcpy_to_page(page, off, (from += len) - len, len))

and
quoted hunk ↗ jump to hunk
@@ -605,35 +461,9 @@ static size_t copy_from_iter_bvec(void *to, size_t bytes, struct iov_iter *i)
[snip]
+	iterate_bvec(i, bytes, page, off, len, true,
+		     memcpy_to_page(page, off, (to += len) - len, len))
should be
+		     memcpy_from_page((to += len) - len, page, off, len))

Sorry, wrong delta.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help