Re: [PATCH 08/17] {macvtap,tun}_get_user(): switch to iov_iter
From: Ben Hutchings <hidden>
Date: 2014-11-24 01:06:34
Also in:
lkml
On Mon, 2014-11-24 at 00:27 +0000, Ben Hutchings wrote:
On Sat, 2014-11-22 at 04:33 +0000, Al Viro wrote:
[...]
Does skb_copy_datagram_from_iter() really need a len parameter? Here it is equal to iov_iter_count(from).
[...]
Again len is equal to iov_iter_count(from), so I think that parameter is redundant.
Having read further patches, I see that unix_stream_sendmsg() is the one exception where the length parameter is different. But maybe the common case (len = iter_iov_count(iov)) deserves a wrapper function? Ben. -- Ben Hutchings Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
Attachments
- signature.asc [application/pgp-signature] 811 bytes