Thread (133 messages) flat view 133 messages, 9 authors, 2015-02-03

Re: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter

From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2014-11-24 10:17:54
Also in: lkml

On Mon, Nov 24, 2014 at 02:00:18AM +0000, Ben Hutchings wrote:
On Sat, 2014-11-22 at 04:39 +0000, Al Viro wrote:
[...]
quoted
-		ret = rds_page_copy_from_user(sg_page(sg), sg->offset + sg_off,
-					      iov->iov_base + iov_off,
-					      to_copy);
[...]

It looks like rds_page_copy{,_from,_to}_user() are all unused after this
change, so you could delete them.
Maybe.  Or maybe add a saner wrapper for rds_page_copy_from_user()...  Separate
story, anyway.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help