Re: [PATCH 1/3] net: Add a test to see if a skb is freeable in irq context
flat view
From: David Miller <davem@davemloft.net>
Date: 2014-03-29 22:09:47
From: ebiederm@xmission.com (Eric W. Biederman) Date: Thu, 27 Mar 2014 18:15:47 -0700
Currently netpoll and skb_release_head_state assume that a skb is freeable in hard irq context except when skb->destructor is set. The reality is far from this. So add a function skb_irq_freeable to compute the full test and in the process be the living documentation of what the requirements are of actually freeing a skb in hard irq context. Signed-off-by: "Eric W. Biederman" <redacted>
...
quoted hunk ↗ jump to hunk
+ return !skb->destructor && +#if IS_ENABLED(CONFIG_XFRM) + !skb->sp && +#endif +#if IS_ENABLED(CONFIG_NF_CONNTRACK) + !skb->nfct && +#endif + !skb->_skb_refdst && + !skb_has_frag_list(skb);
I think you need to add "!skb->nf_bridge &&" to this test.