Re: [PATCH 6/6] net: Free skbs from irqs when possible.
From: Eric W. Biederman <hidden>
Date: 2014-03-18 17:53:08
From: Eric W. Biederman <hidden>
Date: 2014-03-18 17:53:08
Ben Hutchings [off-list ref] writes:
On Mon, 2014-03-17 at 23:27 -0700, Eric W. Biederman wrote: [...]quoted
--- a/net/core/skbuff.c +++ b/net/core/skbuff.c@@ -554,14 +554,21 @@ static void kfree_skbmem(struct sk_buff *skb) static void skb_release_head_state(struct sk_buff *skb) { + WARN_ONCE(in_irq() && !skb_irq_freeable(skb), + "%s called from irq! sp %d nfct %d frag_list %d %pF dst %lx", + __func__, + IS_ENABLED(CONFIG_XFRM) ? !!skb->sp : 0, + IS_ENABLED(CONFIG_NF_CONNTRACK) ? !!skb->nfct : 0,[...] This is a syntax error if CONFIG_XFRM or CONFIG_NF_CONNTRACK is disabled; you have to use #ifdef's.
Doh! That if nothing else definitely calls for a respin of this patch. Eric