Re: [RFC PATCH 1/2] netpoll: Remove dead netpoll_rx code
flat view
From: Eric Dumazet <hidden>
Date: 2014-03-11 12:29:24
On Tue, 2014-03-11 at 01:44 -0700, Eric W. Biederman wrote:
The netpoll_rx code only becomes active if the netpoll rx_skb_hook is implemented. There is not a single implementation of the netpoll rx_skb_hook in the kernel. There are problems with the netpoll packet receive code. Most speifically every packet that makes it to netpoll_neigh_reply is leaked. Given that the netpoll packet receive code is buggy and has not been used for a decade let's just remove it. Signed-off-by: "Eric W. Biederman" <redacted> --- drivers/net/Kconfig | 5 - include/linux/netdevice.h | 17 -- include/linux/netpoll.h | 59 ------ net/core/dev.c | 11 +- net/core/netpoll.c | 471 --------------------------------------------- 5 files changed, 1 insertions(+), 562 deletions(-)
I cannot agree more, thanks Eric. Acked-by: Eric Dumazet <redacted>