Re: [PATCH 02/54] 3c509: Call dev_consume_skb_any instead of dev_kfree_skb.
From: Eric Dumazet <hidden>
Date: 2014-03-25 13:03:21
From: Eric Dumazet <hidden>
Date: 2014-03-25 13:03:21
On Mon, 2014-03-24 at 23:04 -0700, Eric W. Biederman wrote:
From: "Eric W. Biederman" <redacted> Replace dev_kfree_skb with dev_consume_skb_any in el3_start_xmit as it can be called in hard irq and other contexts. dev_consume_skb_any is used as on this simple hardware the skb is consumed directly by the start_xmit function. Signed-off-by: "Eric W. Biederman" <redacted> --- drivers/net/ethernet/3com/3c509.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c index c53384d41c96..35df0b9e6848 100644 --- a/drivers/net/ethernet/3com/3c509.c +++ b/drivers/net/ethernet/3com/3c509.c@@ -749,7 +749,7 @@ el3_start_xmit(struct sk_buff *skb, struct net_device *dev) spin_unlock_irqrestore(&lp->lock, flags); - dev_kfree_skb (skb); + dev_consume_skb_any (skb);
Please remove the space ? Acked-by: Eric Dumazet <edumazet@google.com>