Thread (25 messages) flat view 25 messages, 4 authors, 2012-08-23

Re: [PATCH v6] bonding support for IPv6 transmit hashing

From: Jeremy Brookman <hidden>
Date: 2012-08-22 12:06:46

quoted
        If John signs off and somebody tests this, I'll post a formal
submssion with the full commit message.
Since my last submission I ended up making some changes on my end to
streamline the logic. I can fold together my patch with yours and test them
later tonight. If everything looks good I'll post the changes back to the
list.
Great - thanks for that Jay/John; will look forward to the latest
patch later. I'm actually looking at the 2.6.32 branch so have tested
a backport of Jay's patch (which only took a couple of very minor
modifications); a quick test on an 8-port bond with layer3+4 hashing
looked fine.  (Will hold off until the final patch before doing more
testing.)

Regards,

Jeremy

On Tue, Aug 21, 2012 at 11:21 PM, John Eaglesham [off-list ref] wrote:
On 8/21/2012 12:19 PM, Jay Vosburgh wrote:
quoted
Jeremy Brookman [off-list ref] wrote:
quoted
quoted
You should use a mix of tabs, as necessary, to get things to line up
how I told you they need to line up.

Unless I'm missing something, this change doesn't seem to have made it
through to the kernel tip, but we could really use this bugfix. Is it
in a repository I didn't notice, or not yet through the review?  If
it's not through the review, is any help needed to get it there?

        The submitter (John Eaglesham) never posted an updated version
that addressed the various comments, nor did his original patch
submission include a Signed-off-by.

        I went ahead and updated the patch to address the comments; I've
only compile tested this.  Are you (Jeremy or John) able to test this to
confirm that it will hash ipv6 traffic as expected (I can test it, but
it won't be today)?

        John, can you post a Signed-off-by for your patch (really, this
updated version of your patch)?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help