Re: [PATCH v5] bonding support for IPv6 transmit hashing

From
David Miller <davem@davemloft.net>
Date
2012-07-01 10:33:54
Reply to
John Eaglesham, 2012-07-01
From: John Eaglesham <redacted>
Date: Sun,  1 Jul 2012 01:07:43 -0700
quoted hunk ↗ jump to hunk
+		v6hash =
+			(ipv6h->saddr.s6_addr32[1] ^ ipv6h->daddr.s6_addr32[1]) ^
+			(ipv6h->saddr.s6_addr32[2] ^ ipv6h->daddr.s6_addr32[2]) ^
+			(ipv6h->saddr.s6_addr32[3] ^ ipv6h->daddr.s6_addr32[3]);
You completely ignored my feedback:

	This is rediculous, just put &ipv6h->saddr into a local
	pointer named 's' and then you won't have use such gymnastics
	to indent the code.
Thread (25 messages) 25 messages, 4 authors, last reply 2012-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help