Re: [PATCH v5] bonding support for IPv6 transmit hashing

On 7/1/2012 3:33 AM, David Miller wrote:

From: John Eaglesham <redacted>
Date: Sun,  1 Jul 2012 01:07:43 -0700

quoted

+		v6hash =
+			(ipv6h->saddr.s6_addr32[1] ^ ipv6h->daddr.s6_addr32[1]) ^
+			(ipv6h->saddr.s6_addr32[2] ^ ipv6h->daddr.s6_addr32[2]) ^
+			(ipv6h->saddr.s6_addr32[3] ^ ipv6h->daddr.s6_addr32[3]);

You completely ignored my feedback:

	This is rediculous, just put &ipv6h->saddr into a local
	pointer named 's' and then you won't have use such gymnastics
	to indent the code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

My apologies, I completely misunderstood your feedback. I will make the 
correction and re-submit.

Thanks.

John