Thread (25 messages) flat view 25 messages, 4 authors, 2012-08-23

Re: [PATCH v6] bonding support for IPv6 transmit hashing

From: David Miller <davem@davemloft.net>
Date: 2012-07-03 05:43:56

From: John Eaglesham <redacted>
Date: Mon, 02 Jul 2012 22:38:05 -0700
On 7/2/2012 10:14 PM, David Miller wrote:
quoted
From: John Eaglesham <redacted>
Date: Mon, 02 Jul 2012 22:01:20 -0700
quoted
I replaced the mixed tabs and spaces with all tabs when I updated that
function, but in retrospect the tabs and spaces were likely
intentional. I will revert.
They were.  Don't change existing coding style unless you are certain
it is wrong.

Besides any such changes are completely outside of the scope of
the changes you are making, so you should have left them out in
any event.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Should the indents in the code I am adding follow the style guide and
use only tabs, or follow the style already present and mix spaces and
tabs for indentation?
You should use a mix of tabs, as necessary, to get things to line up
how I told you they need to line up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help