Thread (21 messages) 21 messages, 6 authors, 2012-08-11

Re: [PATCH 7/8] bridge: add some comments for NETDEV_RELEASE

flat view

From: Joe Perches <joe@perches.com>
Date: 2012-08-10 11:13:19

On Fri, 2012-08-10 at 12:59 +0200, Jan Engelhardt wrote:
On Tuesday 2012-08-07 01:39, Joe Perches wrote:
quoted
On Mon, 2012-08-06 at 13:50 -0700, David Miller wrote:
quoted
quoted
+	/*
+	 * We don't notify NETDEV_RELEASE event, as this will
+	 * stop netconsole on the bridge.
+	 */
Please format comments in the networking:

	/* Like
	 * this.
	 */
Maybe add a networking specific block comment style
to checkpatch. This doesn't trigger on files outside
of drivers/net and net.
Is there any particular reason why net/ wants to be special?
A determined maintainer with a strong desire
for consistency using an idiomatic style.

A thread about it:
https://lkml.org/lkml/2012/4/16/443
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help