[Resend PATCH 7/8] bridge: add some comments for NETDEV_RELEASE
flat view
STALE5187d
From: Cong Wang <hidden>
Date: 2012-08-07 05:59:23
Subsystem:
ethernet bridge, networking [general], the rest · Maintainers:
Nikolay Aleksandrov, Ido Schimmel, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Add comments on why we don't notify NETDEV_RELEASE. Cc: David Miller <davem@davemloft.net> Cc: Stephen Hemminger <redacted> Signed-off-by: Cong Wang <redacted> ---
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index 171fd6b..bf47d4f 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c@@ -427,6 +427,9 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) if (!p || p->br != br) return -EINVAL; + /* We don't notify NETDEV_RELEASE event, as this will + * stop netconsole on the bridge. + */ del_nbp(p); spin_lock_bh(&br->lock);