[PATCH 7/8] bridge: add some comments for NETDEV_RELEASE
flat view
STALE5178d
SUPERSEDED
From: Cong Wang <hidden>
Date: 2012-08-06 14:24:02
Subsystem:
ethernet bridge, networking [general], the rest · Maintainers:
Nikolay Aleksandrov, Ido Schimmel, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Revision v2 of 4 in this series.
Revisions (4)
- v2 current
- v3 [diff vs current]
- v4 [diff vs current]
- v5 [diff vs current]
Add comments on why we don't notify NETDEV_RELEASE. Cc: Stephen Hemminger <redacted> Signed-off-by: Cong Wang <redacted> --- net/bridge/br_if.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index 171fd6b..910f4aa 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c@@ -427,6 +427,10 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) if (!p || p->br != br) return -EINVAL; + /* + * We don't notify NETDEV_RELEASE event, as this will + * stop netconsole on the bridge. + */ del_nbp(p); spin_lock_bh(&br->lock);
--
1.7.7.6