Re: [PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr()
From: Sven Eckelmann <hidden>
Date: 2012-02-09 08:52:45
Also in:
batman, lkml
On Wednesday 08 February 2012 22:10:47 Danny Kukawka wrote:
quoted hunk ↗ jump to hunk
Use dev_hw_addr_random() instead of calling random_ether_addr() to set addr_assign_type correctly to NET_ADDR_RANDOM. Reset the state to NET_ADDR_PERM as soon as the MAC get changed via .ndo_set_mac_address. Signed-off-by: Danny Kukawka <redacted> --- net/batman-adv/soft-interface.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)diff --git a/net/batman-adv/soft-interface.cb/net/batman-adv/soft-interface.c index 987c75a..865a485 100644--- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c@@ -541,6 +541,9 @@ static int interface_set_mac_addr(struct net_device*dev, void *p) } memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN); + if (dev->addr_assign_type & NET_ADDR_RANDOM) + dev->addr_assign_type ^= NET_ADDR_RANDOM; + return 0; }
Why not something like dev->addr_assign_type &= ~NET_ADDR_RANDOM; ? It is a relative common way inside the kernel to do this kind of stuff. Thanks, Sven PS: For the batman-adv people. This functionality was introduced with 2.6.36.
Attachments
- signature.asc [application/pgp-signature] 836 bytes