Re: [PATCH 09/50] Cadence MACB: use dev_hw_addr_random() instead of random_ether_addr()
From: Nicolas Ferre <hidden>
Date: 2012-02-09 08:25:23
Also in:
lkml
On 02/08/2012 10:10 PM, Danny Kukawka :
Use dev_hw_addr_random() instead of calling random_ether_addr() to set addr_assign_type correctly to NET_ADDR_RANDOM. Signed-off-by: Danny Kukawka <redacted>
Danny, You can add my "Acked-by" even if you rework this series... Acked-by: Nicolas Ferre <redacted> Thanks, best regards,
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/cadence/macb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 2320068..3ee8d79 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c@@ -87,7 +87,7 @@ static void __init macb_get_hwaddr(struct macb *bp) memcpy(bp->dev->dev_addr, addr, sizeof(addr)); } else { netdev_info(bp->dev, "invalid hw address, using random\n"); - random_ether_addr(bp->dev->dev_addr); + dev_hw_addr_random(bp->dev, bp->dev->dev_addr); } }
-- Nicolas Ferre