[RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Danny Kukawka <hidden> · 2012-02-08
[PATCH 08/50] bnx2x: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
RE: [PATCH 08/50] bnx2x: use dev_hw_addr_random() instead of random_ether_addr() · David Laight <hidden> · 2012-02-09
[PATCH 09/50] Cadence MACB: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 09/50] Cadence MACB: use dev_hw_addr_random() instead of random_ether_addr() · Nicolas Ferre <hidden> · 2012-02-09
[PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called · Stephen Hemminger <hidden> · 2012-02-08
Re: [PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called · Danny Kukawka <hidden> · 2012-02-08
[PATCH 02/50] smsc95xx: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 02/50] smsc95xx: use dev_hw_addr_random() instead of random_ether_addr() · Sergei Shtylyov <hidden> · 2012-02-09
[PATCH 06/50] dummy: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 03/50] smsc75xx: se dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 04/50] adi/blackfin: set addr_assign_type correctly if random · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 04/50] adi/blackfin: set addr_assign_type correctly if random · Bob Liu <hidden> · 2012-02-09
Re: [PATCH 04/50] adi/blackfin: set addr_assign_type correctly if random · Mike Frysinger <hidden> · 2012-02-09
[PATCH 32/50] tile_net: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 31/50] tc35815: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 30/50] atheros eth: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 29/50] micrel eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 27/50] davinci_emac: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 07/50] au1000_eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 26/50] faraday: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 28/50] forcedeth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 16/50] pxa168_eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 50/50] use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 49/50] openvswitch: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 47/50] bridge: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 47/50] bridge: use dev_hw_addr_random() instead of random_ether_addr() · Stephen Hemminger <hidden> · 2012-02-08
[PATCH 48/50] ip_gre.c: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 17/50] enc28j60: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 14/50] ethoc: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 13/50] dnet: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 10/50] Calxeda XGMAC: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 12/50] dm9000: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 15/50] lantiq_etop: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 25/50] via-rhine: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 24/50] sis900: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 24/50] sis900: use dev_hw_addr_random() instead of random_ether_addr() · Daniele Venzano <venza@brownhat.org> · 2012-02-11
[PATCH 21/50] smsc9420: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 18/50] mipsnet: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 19/50] macsonic: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 22/50] r6040: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 23/50] efx: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 23/50] efx: use dev_hw_addr_random() instead of random_ether_addr() · Ben Hutchings <hidden> · 2012-02-08
[PATCH 45/50] tun: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 44/50] team: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 43/50] macvlan: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [B.A.T.M.A.N.] [PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr() · Sven Eckelmann <sven@narfation.org> · 2012-02-09
Re: [B.A.T.M.A.N.] [PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr() · Marek Lindner <hidden> · 2012-02-11
[PATCH 35/50] ifb: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 34/50] xilinx ll_temac: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 41/50] l2tp_eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr() · "Michael S. Tsirkin" <mst@redhat.com> · 2012-02-09
[PATCH 36/50] igbvf: reset netdevice addr_assign_type if changed from random · Danny Kukawka <hidden> · 2012-02-08
[PATCH 33/50] stmmac: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 46/50] wan: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 39/50] veth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used · Oliver Neukum <oliver@neukum.org> · 2012-02-08
Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 20/50] smsc911x: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 20/50] smsc911x: use dev_hw_addr_random() instead of random_ether_addr() · Mark Brown <hidden> · 2012-02-09
[PATCH 11/50] ep93xx: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
RE: [PATCH 11/50] ep93xx: use dev_hw_addr_random() instead of random_ether_addr() · H Hartley Sweeten <hidden> · 2012-02-08
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Stephen Hemminger <hidden> · 2012-02-08
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Danny Kukawka <hidden> · 2012-02-09
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Stephen Hemminger <hidden> · 2012-02-09
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · David Miller <davem@davemloft.net> · 2012-02-08
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Danny Kukawka <hidden> · 2012-02-09
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · David Miller <davem@davemloft.net> · 2012-02-09

Re: [PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called

From: Danny Kukawka <hidden>
Date: 2012-02-08 22:58:25
Also in: lkml

On Mittwoch, 8. Februar 2012, Stephen Hemminger wrote:

On Wed,  8 Feb 2012 22:10:08 +0100

Danny Kukawka [off-list ref] wrote:

quoted

+	if (dev->addr_assign_type & NET_ADDR_RANDOM)
+		dev->addr_assign_type ^= NET_ADDR_RANDOM;

Why not just avoid the conditional, or better yet use bitops?

	dev->addr_assign_type &= ~NET_ADDR_RANDOM;

Okay, If I have comments on the other patches back, I will send new versions 
which avoid the if. Thanks for the hint.

Danny

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help