[RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Danny Kukawka <hidden> · 2012-02-08
[PATCH 08/50] bnx2x: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
RE: [PATCH 08/50] bnx2x: use dev_hw_addr_random() instead of random_ether_addr() · David Laight <hidden> · 2012-02-09
[PATCH 09/50] Cadence MACB: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 09/50] Cadence MACB: use dev_hw_addr_random() instead of random_ether_addr() · Nicolas Ferre <hidden> · 2012-02-09
[PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called · Stephen Hemminger <hidden> · 2012-02-08
Re: [PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called · Danny Kukawka <hidden> · 2012-02-08
[PATCH 02/50] smsc95xx: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 02/50] smsc95xx: use dev_hw_addr_random() instead of random_ether_addr() · Sergei Shtylyov <hidden> · 2012-02-09
[PATCH 06/50] dummy: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 03/50] smsc75xx: se dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 04/50] adi/blackfin: set addr_assign_type correctly if random · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 04/50] adi/blackfin: set addr_assign_type correctly if random · Bob Liu <hidden> · 2012-02-09
Re: [PATCH 04/50] adi/blackfin: set addr_assign_type correctly if random · Mike Frysinger <hidden> · 2012-02-09
[PATCH 32/50] tile_net: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 31/50] tc35815: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 30/50] atheros eth: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 29/50] micrel eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 27/50] davinci_emac: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 07/50] au1000_eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 26/50] faraday: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 28/50] forcedeth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 16/50] pxa168_eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 50/50] use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 49/50] openvswitch: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 47/50] bridge: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 47/50] bridge: use dev_hw_addr_random() instead of random_ether_addr() · Stephen Hemminger <hidden> · 2012-02-08
[PATCH 48/50] ip_gre.c: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 17/50] enc28j60: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 14/50] ethoc: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 13/50] dnet: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 10/50] Calxeda XGMAC: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 12/50] dm9000: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 15/50] lantiq_etop: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 25/50] via-rhine: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 24/50] sis900: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 24/50] sis900: use dev_hw_addr_random() instead of random_ether_addr() · Daniele Venzano <venza@brownhat.org> · 2012-02-11
[PATCH 21/50] smsc9420: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 18/50] mipsnet: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 19/50] macsonic: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 22/50] r6040: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 23/50] efx: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 23/50] efx: use dev_hw_addr_random() instead of random_ether_addr() · Ben Hutchings <hidden> · 2012-02-08
[PATCH 45/50] tun: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 44/50] team: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 43/50] macvlan: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [B.A.T.M.A.N.] [PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr() · Sven Eckelmann <sven@narfation.org> · 2012-02-09
Re: [B.A.T.M.A.N.] [PATCH 40/50] batman-adv: use dev_hw_addr_random() instead of random_ether_addr() · Marek Lindner <hidden> · 2012-02-11
[PATCH 35/50] ifb: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 34/50] xilinx ll_temac: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 41/50] l2tp_eth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 42/50] virtio_net: use dev_hw_addr_random() instead of random_ether_addr() · "Michael S. Tsirkin" <mst@redhat.com> · 2012-02-09
[PATCH 36/50] igbvf: reset netdevice addr_assign_type if changed from random · Danny Kukawka <hidden> · 2012-02-08
[PATCH 33/50] stmmac: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 46/50] wan: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 39/50] veth: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
[PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used · Oliver Neukum <oliver@neukum.org> · 2012-02-08
Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used · Danny Kukawka <hidden> · 2012-02-08
[PATCH 20/50] smsc911x: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
Re: [PATCH 20/50] smsc911x: use dev_hw_addr_random() instead of random_ether_addr() · Mark Brown <hidden> · 2012-02-09
[PATCH 11/50] ep93xx: use dev_hw_addr_random() instead of random_ether_addr() · Danny Kukawka <hidden> · 2012-02-08
RE: [PATCH 11/50] ep93xx: use dev_hw_addr_random() instead of random_ether_addr() · H Hartley Sweeten <hidden> · 2012-02-08
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Stephen Hemminger <hidden> · 2012-02-08
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Danny Kukawka <hidden> · 2012-02-09
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Stephen Hemminger <hidden> · 2012-02-09
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · David Miller <davem@davemloft.net> · 2012-02-08
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · Danny Kukawka <hidden> · 2012-02-09
Re: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice · David Miller <davem@davemloft.net> · 2012-02-09

STALE5301d

[PATCH 08/50] bnx2x: use dev_hw_addr_random() instead of random_ether_addr()

From: Danny Kukawka <hidden>
Date: 2012-02-08 21:11:17
Also in: lkml
Subsystem: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest · Maintainers: Sudarsana Kalluru, Manish Chopra, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Use dev_hw_addr_random() instead of calling random_ether_addr()
to set addr_assign_type correctly to NET_ADDR_RANDOM.

Reset the state to NET_ADDR_PERM as soon as the MAC get
changed via .ndo_set_mac_address.

Signed-off-by: Danny Kukawka <redacted>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  |    2 ++
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
index 03f3935..c21acf3 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

@@ -3009,6 +3009,8 @@ int bnx2x_change_mac_addr(struct net_device *dev, void *p)
 	}
 
 	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
+	if (dev->addr_assign_type & NET_ADDR_RANDOM)
+		dev->addr_assign_type ^= NET_ADDR_RANDOM;
 
 	if (netif_running(dev))
 		rc = bnx2x_set_eth_mac(bp, true);

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 1e3f978..ff82dc9 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

@@ -9605,7 +9605,7 @@ static void __devinit bnx2x_get_mac_hwinfo(struct bnx2x *bp)
 
 	if (BP_NOMCP(bp)) {
 		BNX2X_ERROR("warning: random MAC workaround active\n");
-		random_ether_addr(bp->dev->dev_addr);
+		dev_hw_addr_random(bp->dev, bp->dev->dev_addr);
 	} else if (IS_MF(bp)) {
 		val2 = MF_CFG_RD(bp, func_mf_config[func].mac_upper);
 		val = MF_CFG_RD(bp, func_mf_config[func].mac_lower);

-- 
1.7.7.3