Re: [PATCH v4] net: add Faraday FTMAC100 10/100 Ethernet driver

Dear Eric,

On Fri, Jan 21, 2011 at 5:08 PM, Eric Dumazet [off-list ref] wrote:

Le vendredi 21 janvier 2011 à 15:55 +0800, Po-Yu Chuang a écrit :
...

quoted

+
+     dma_unmap_single(priv->dev, map, skb_headlen(skb), DMA_TO_DEVICE);
+
+     dev_kfree_skb_irq(skb);
+
+     ftmac100_txdes_reset(txdes);
+
+     ftmac100_tx_clean_pointer_advance(priv);
+
+     priv->tx_pending--;
+     netif_wake_queue(netdev);
+
+     return true;
+}
+

Thanks to NAPI, you can free skb directly, not queuing it via
NET_TX_SOFTIRQ softirq, using dev_kfree_skb() instead of
dev_kfree_skb_irq()

Fixed. Thanks a lot.

best regards,
Po-Yu Chuang