Thread (72 messages) 72 messages, 7 authors, 2011-03-03

Re: [PATCH v3] net: add Faraday FTMAC100 10/100 Ethernet driver

flat view

From: Po-Yu Chuang <hidden>
Date: 2011-01-20 15:43:41
Also in: lkml

Dear Eric,

On Thu, Jan 20, 2011 at 11:35 PM, Eric Dumazet [off-list ref] wrote:
Le jeudi 20 janvier 2011 à 23:30 +0800, Po-Yu Chuang a écrit :
quoted
+     /* push packet to protocol stack */
+     netif_receive_skb(skb);
+
+     netdev->stats.rx_packets++;
+     netdev->stats.rx_bytes += skb->len;
+
+     (*processed)++;
+
+     return true;
+}
+
Hmm, after call to netif_receive_skb(skb), you are not allowed to access
skb anymore (maybe it was freed)

netdev->stats.rx_packets++;
netdev->stats.rx_bytes += skb->len;
netif_receive_skb(skb);
Wow, you are totally right.

Thanks,
Po-Yu Chuang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help