Re: [PATCH] netfilter: per netns nf_conntrack_cachep
From: Jon Masters <hidden>
Date: 2010-02-04 13:42:56
Also in:
lkml, netfilter-devel
From: Jon Masters <hidden>
Date: 2010-02-04 13:42:56
Also in:
lkml, netfilter-devel
On Thu, 2010-02-04 at 14:37 +0100, Patrick McHardy wrote:
Jon Masters wrote:quoted
On Thu, 2010-02-04 at 14:04 +0100, Patrick McHardy wrote:quoted
In any case, we need a fix for this suitable for 2.6.33. If you don't like using the pointer, please send a patch to add an id to the network namespaces.Right. I think the quick solution is fine for 2.6.33. So that makes the hashtable non-resize patch, the crash fix, and the cachep bits. I will try to get involved and help you out with the per-ns hashtable clean rather than just being a whiner :)This is the patch I'm going to commit unless unless there are further objections. Its Eric's patch with a change on top to allocate a unique name for the slab.quoted
Thanks a bunch! Fedora kernels have already been built with this fix, since it will allow us to close a fair number of "KVM goes boom" bugs.Thanks as well for your help.
Patch looks fine to me for the moment, unless it *really* matters about the pointer exposure. Jon.