Re: [PATCH] netfilter: per netns nf_conntrack_cachep
From: Jon Masters <hidden>
Date: 2010-02-02 18:40:05
Also in:
lkml, netfilter-devel
From: Jon Masters <hidden>
Date: 2010-02-02 18:40:05
Also in:
lkml, netfilter-devel
On Tue, 2010-02-02 at 19:36 +0100, Patrick McHardy wrote:
Jon Masters wrote:quoted
On Tue, 2010-02-02 at 19:58 +0200, Alexey Dobriyan wrote:quoted
Yes, moving to init_net-only function is fine.So moving the "setup up fake conntrack" bits to init_init_net from init_net still results in the panic, which means that the use count really is dropping to zero and we really are trying to free it when using multiple namespaces. Per ns is probably an easier way to go.Agreed, that will also avoid problems in the future with the ct_net pointer pointing to &init_net. I'll take care of this tommorrow.
Ok. I'll leave this box running with the hack. I think at the very least that this specific issue needs to get fixed and in the stable tree, then the other bits (per namespace cachep...) are probably a good idea at the same time but that's up to you. Thanks for your help! Jon.