Re: [PATCH] netfilter: per netns nf_conntrack_cachep
From: Patrick McHardy <hidden>
Date: 2010-02-03 12:10:45
Also in:
lkml, netfilter-devel
From: Patrick McHardy <hidden>
Date: 2010-02-03 12:10:45
Also in:
lkml, netfilter-devel
Patrick McHardy wrote:
Jon Masters wrote:quoted
On Tue, 2010-02-02 at 19:58 +0200, Alexey Dobriyan wrote:quoted
Yes, moving to init_net-only function is fine.So moving the "setup up fake conntrack" bits to init_init_net from init_net still results in the panic, which means that the use count really is dropping to zero and we really are trying to free it when using multiple namespaces. Per ns is probably an easier way to go.Agreed, that will also avoid problems in the future with the ct_net pointer pointing to &init_net. I'll take care of this tommorrow.
Unfortunately a per-namespace conntrack is not easily possible without larger changes (most of which are already queued in nf-next-2.6.git though). So for now I just moved the untrack handling to the init_net setup and cleanup functions and we can try to fix the remainder in 2.6.34. Jon, could you give this patch a try please?