Thread (63 messages) 63 messages, 4 authors, 2010-02-04

Re: PROBLEM with summary: Re: [PATCH] netfilter: per netns nf_conntrack_cachep

From: Eric Dumazet <hidden>
Date: 2010-02-02 17:22:28
Also in: lkml, netfilter-devel

Le mardi 02 février 2010 à 18:04 +0100, Patrick McHardy a écrit :
Ah nice catch, that seems to be the problem. When the untracked
conntrack is already attached to an skb and thus has refcnt > 1
and we re-initalize the refcnt, it will get freed.

The question is whether the ct_net pointer of the untracked conntrack
is actually required. If so, we need one instance per namespace,
otherwise we can just move initialization and cleanup to the init_net
init/cleanup functions. Alexey, do you happen to know this?
One untracked per netns seems the way to go, and move it outside of
read_mostly area too, we obviously can modify its refcount frequently...


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help