Re: [RFC] [PATCH] Don't run __qdisc_run() on a stopped TX queue
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-07-29 12:30:49
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-07-29 12:30:49
On Wed, Jul 29, 2009 at 11:26:14AM +0000, Jarek Poplawski wrote:
If you mean the tx lock there should be no "real" contention: only one waiter max. qdisc lock's contention might be higher, but it's use (during contention) better: enqueue + dequeue together instead of doing it separately.
Hmm, you will have contention if they're both transmitting a single flow which must always go into a single physical queue. So you'll have two CPUs doing the work of a single CPU, with one of them always spinning on the TX lock. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt