Re: [RFC] [PATCH] Don't run __qdisc_run() on a stopped TX queue
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-07-25 11:12:18
On Sat, Jul 25, 2009 at 01:04:09PM +0200, Jarek Poplawski wrote:
It would be nice to establish what difference is made by each part of this patch. The check for stopped queue before each skb xmit was done earlier too, so it's not exactly multiqueue penalization.
No, but getting into qdisc_restart when we know that the queue is stopped is just silly. The only reason that is done right now is because of the pathological case where a packet on qdisc X maps to hardware queue Y. This is something which almost nobody uses and yet it penalises everybody. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt