Re: [RFC] [PATCH] Don't run __qdisc_run() on a stopped TX queue
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-07-29 02:12:22
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-07-29 02:12:22
On Tue, Jul 28, 2009 at 06:34:51PM -0700, David Miller wrote:
Wouldn't that bypass any rate limiting enforcement done by the qdisc too?
You'd only bypass it for the default qdisc (or any other qdisc that didn't care). It can either be achived through a flag as Krishna proposed or perhaps we can make the qdisc's enqueue function return a special value that indicates the packet can be dequeued immediately and given to the hardware. I don't have a good answer for how we can achieve CPU scalability for rate limiting qdiscs yet. However, that shouldn't stop us from getting better CPU scalability for the default qdisc which is what most people will use for the time being. One possibility is to partition the bandwidth equally between the queues and apply rate limiting locally within each queue. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt