Re: [PATCH] tcp: make urg+gso work for real this time
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-12-17 21:29:24
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-12-17 21:29:24
On Wed, Dec 17, 2008 at 06:30:15PM +0300, Alexey Kuznetsov wrote:
Hello!quoted
Probably, netbsd/openbsd have some another quirk to work this around. I do not see how, though.F.e. this could be totally safe if we do this only in the case when octet seq+0xFFFF has not yet been sent. When we send segment with 0xFFFF inside urg_ptr is advanced and so on, so that receiver has no chances to corrupt stream. I.e. we set URG and urg_ptr to fake scb->seq + 0xFFFF only when: after(scb->seq + 0xFFFF, tp->snd_nxt) My brains are rusty, so take this critically. :-)
Indeed that's a great idea! Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt