Re: [PATCH] tcp: make urg+gso work for real this time
From: David Miller <davem@davemloft.net>
Date: 2008-12-04 05:25:42
From: "Ilpo Järvinen" <redacted> Date: Wed, 3 Dec 2008 20:31:09 +0200 (EET)
On Wed, 3 Dec 2008, Petr Tesarik wrote:quoted
Ilpo Järvinen píse v St 03. 12. 2008 v 13:22 +0200: Yes, re-fragmenting the packet here is probably the best way to go. But repeating the same condition on multiple places is not so nice. What about this little improvement?Yeah, this too will work... Though not of too much significance since I've already most of unification of those two functions in a local queue awaiting testing, polish up and submit to net-next. When sending an updated version davem prefers to have full changelog in it btw, it saves some work for him.quoted
(I didn't roll the revert of 33cf71cee1 into it, as it makes the actual change less obvious. I think there are better ways of doing a revert in git.)Whatever, I've no strong opinion either way though it's just broken with and without the revert anyway, the full thing is needed to actually fix it.
I've applied Ilpo's version of the fix patch, thanks everyone.