Re: [PATCH] tcp: make urg+gso work for real this time
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-12-17 10:42:59
On Wed, Dec 17, 2008 at 09:31:29PM +1100, Herbert Xu wrote:
Oh I see what you mean now. Yes this isn't as easy as it appears.
Reading RFC 793 again, it seems that what we're doing may not be correct. It would appear that the intention is to flag urgent mode as soon as urgent data appears from the user, regardless of whether it's 64K or more beyond the current sequence number. The fact that the pointer is 16 bits long is not an issue. We should setting it to 0xffff. The way we do it currently means that if there is loads of data in the pipe then we don't signal urgent mode at all until we're within 64K of snd.up, which defeats the whole point of urgent mode. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt