Re: [PATCH] tcp: make urg+gso work for real this time
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-12-17 11:26:11
On Wed, Dec 17, 2008 at 11:52:23AM +0100, Petr Tesarik wrote:
In short, if you keep urg_ptr at 0xffff while moving forward in the stream, the receiving side will interpret it as multiple urgent data. Not quite what you want, I think.
I just checked NetBSD and guess what, they do exactly what I've
suggested:
if (SEQ_GT(tp->snd_up, tp->snd_nxt)) {
u_int32_t urp = tp->snd_up - tp->snd_nxt;
if (urp > IP_MAXPACKET)
urp = IP_MAXPACKET;
th->th_urp = htons((u_int16_t)urp);
th->th_flags |= TH_URG;
} else
So if you think this is bad then it's been there for decades :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt