Re: [PATCH 2/2] udp: RCU handling for Unicast packets.
From: Eric Dumazet <hidden>
Date: 2008-10-30 05:52:28
From: Eric Dumazet <hidden>
Date: 2008-10-30 05:52:28
David Miller a écrit :
From: Eric Dumazet <redacted> Date: Wed, 29 Oct 2008 23:08:30 +0100quoted
@@ -1746,7 +1753,7 @@ void __init udp_table_init(struct udp_table *table) int i; for (i = 0; i < UDP_HTABLE_SIZE; i++) { - INIT_HLIST_HEAD(&table->hash[i].head); + table->hash[i].head.first = (struct hlist_node *)i;Please hide this behind some list.h interface macro, even something as simple as INIT_HLIST_HEAD_NULLS(X, index) would suffice. And as Corey said, the code needs more comments for something as clever as this! :-)
Yes I agree 100%, please give me one day to prepare a real patch, or else akpm will kill us :)