On Tue, Oct 28, 2008 at 02:23:55PM -0700, Christian Bell (christian@myri.com) wrote:

quoted

+	} else {
+		hslot = &udptable->hash[udp_hashfn(net, snum)];
+		write_lock_bh(&hslot->lock);
+		if (udp_lib_lport_inuse(net, snum, hslot, sk, saddr_comp))
+			goto fail;

The fail: label below should still unlock_bh when the above condition  
fails.

This should be new label actually, since it is also used for non-locked
fail.

-- 
	Evgeniy Polyakov