Thread (22 messages) flat view 22 messages, 5 authors, 2008-10-13

Re: [patch 4/4] mISDN: misc timerdev fixes

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-10-13 02:12:12

On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig [off-list ref] wrote:

The bogus version which removes ->llseek just got into Linus' tree..
Well I still have this queued:

From: Andrew Morton <akpm@linux-foundation.org>

Cc: Andi Kleen <redacted>
Cc: Karsten Keil <redacted>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/isdn/mISDN/timerdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix drivers/isdn/mISDN/timerdev.c
--- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix
+++ a/drivers/isdn/mISDN/timerdev.c
@@ -61,7 +61,7 @@ mISDN_open(struct inode *ino, struct fil
 	init_waitqueue_head(&dev->wait);
 	filep->private_data = dev;
 	__module_get(THIS_MODULE);
-	return 0;
+	return nonseekable_open(ino, filep);
 }
 
 static int
_


So presumably whoever merged the unfixed version flubbed the fix.

If that'll fix it.  Is it sufficient?  I think so.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help