Re: [patch 4/4] mISDN: misc timerdev fixes II

On Tue, Sep 23, 2008 at 11:58:44AM -0400, Christoph Hellwig wrote:

On Tue, Sep 23, 2008 at 04:17:40PM +0200, Andi Kleen wrote:

quoted

quoted

quoted

quoted

 static struct file_operations mISDN_fops = {
-	.llseek		= mISDN_llseek,

This is wrong.  no llseek means we use default_llseek, which is
different from returning -ESPIPE.

so.. this?

Hmm actually on double checking it's really needed, sorry.

Yes, unfortunately the only way it's cleared currently is through using
nonseekable_open, but I've started preparing a war plan to sort this whole
mess out.

Yes it would be much more logical if FMODE_SEEK was cleared on character devices
by default. That is what I assumed with the original patch.

-Andi

-- 
ak@linux.intel.com