Thread (22 messages) flat view 22 messages, 5 authors, 2008-10-13

Re: [patch 4/4] mISDN: misc timerdev fixes

From: Christoph Hellwig <hch@infradead.org>
Date: 2008-09-23 10:40:31

On Mon, Sep 22, 2008 at 02:51:03PM -0700, akpm@linux-foundation.org wrote:
From: Andi Kleen <redacted>

- Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.
-static loff_t
-mISDN_llseek(struct file *filep, loff_t offset, int orig)
-{
-	return -ESPIPE;
-}
 static struct file_operations mISDN_fops = {
-	.llseek		= mISDN_llseek,
This is wrong.  no llseek means we use default_llseek, which is
different from returning -ESPIPE.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help