Re: [patch 4/4] mISDN: misc timerdev fixes

On Tue, Sep 23, 2008 at 06:40:26AM -0400, Christoph Hellwig wrote:

On Mon, Sep 22, 2008 at 02:51:03PM -0700, akpm@linux-foundation.org wrote:

quoted

From: Andi Kleen <redacted>

- Remove noop VFS stubs. The VFS does that on a NULL pointer anyways.

quoted

-static loff_t
-mISDN_llseek(struct file *filep, loff_t offset, int orig)
-{
-	return -ESPIPE;
-}

quoted

 static struct file_operations mISDN_fops = {
-	.llseek		= mISDN_llseek,

This is wrong.  no llseek means we use default_llseek, which is
different from returning -ESPIPE.

No it's correct. Character devices don't have FMODE_LSEEK set 
and then no_llseek is the default fallback.

-Andi
-- 
ak@linux.intel.com