On Tue, Sep 23, 2008 at 04:30:06PM +0300, Timo Teräs wrote:

I have no strong opinion either way. So what ever you want, I'm
happy to provide a patch for.

Let's just leave it as it is for now.

quoted

What about xfrm_cfg_mutex?

It's used only in xfrm_state_gc_task. xfrm_state_walk_{init,done}
touch xfrm_state_walks list without locking properly. At least in
the version I'm looking (= net-next-2.6 via git web interface).

Their callers should be holding it.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt