Re: xfrm_state locking regression...
From: David Miller <davem@davemloft.net>
Date: 2008-09-09 00:25:19
From: David Miller <davem@davemloft.net>
Date: 2008-09-09 00:25:19
From: Herbert Xu <herbert@gondor.apana.org.au> Date: Fri, 5 Sep 2008 21:55:07 +1000
ipsec: Use RCU-like construct for saved state within a walk
Ok, now that I finally understand how this works I like it. The only comment I would make is that maybe it's a bit excessive to trigger the GC worker every time we walk the states. Instead you could expose the GC task's local list go: xfrm_state_walk_completed++; smp_wmb(); if (!list_empty(&xfrm_state_gc_work_list)) schedule_work(&xfrm_state_gc_work); in xfrm_state_walk_done().