Re: xfrm_state locking regression...
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-23 12:14:21
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-23 12:14:21
On Tue, Sep 23, 2008 at 03:08:08PM +0300, Timo Teräs wrote:
+ list_for_each_entry(walk, &xfrm_state_walks, list) {
+ if (walk->state == x)
+ walk->state = next;
+ }Just make a new list in xfrm_state that has all the dumpers sitting on it. In fact all you need is a hlist, or even just a pointer. Walking through an unbounded list on the fast path is not good :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt