On Thu, Aug 07, 2008 at 03:10:58AM -0700, David Miller wrote:

From: Jarek Poplawski <redacted>
Date: Thu, 7 Aug 2008 10:09:10 +0000

...

quoted

After some checking it looks mostly OK to me, but one thing: in
sch_gred gred_drop() calls qdisc_drop(), so now it needs kfree_skb().
BTW, maybe it would be nicer to add __qdisc_drop() for these new
things?

qdisc_drop() sets the new __NET_XMIT_KFREE bit, but sch_gred wants to
return NET_XMIT_CN, so I OR'd in the __NET_XMIT_KFREE bit there.

Hmm... I'm not sure we're thinking about the same function?

Jarek P.